raulcd commented on code in PR #34:
URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1928409957
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -126,3 +126,77 @@ endfunction()
if(ICEBERG_ARROW)
resolve_arrow_dependency()
endif()
+
+# ----------------------------------------------------------------------
+# Apache Avro
+
+function(resolve_avro_dependency)
+ prepare_fetchcontent()
+
+ set(AVRO_USE_BOOST
+ OFF
+ CACHE BOOL "" FORCE)
+
+ set(AVRO_BUILD_EXECUTABLES
+ OFF
+ CACHE BOOL "" FORCE)
+
+ set(AVRO_BUILD_TESTS
+ OFF
+ CACHE BOOL "" FORCE)
+
+ fetchcontent_declare(Avro
+ ${FC_DECLARE_COMMON_OPTIONS}
+ # TODO: switch to upstream once the PR below is merged
+ # https://github.com/apache/avro/pull/3299
+ # Eventually, we should switch to Apache Avro 1.3.0.
+ GIT_REPOSITORY https://github.com/wgtmac/avro.git
Review Comment:
Great work @wgtmac
##########
ci/scripts/build_example.sh:
##########
@@ -25,10 +25,27 @@ build_dir=${1}/build
mkdir ${build_dir}
pushd ${build_dir}
-cmake \
- -DCMAKE_PREFIX_PATH=${CMAKE_INSTALL_PREFIX:-${ICEBERG_HOME}} \
- ${source_dir}
-cmake --build .
+is_windows() {
+ [[ "${OSTYPE}" == "msys" || "${OSTYPE}" == "win32" ]]
+}
+
+CMAKE_ARGS=(
+ "-DCMAKE_PREFIX_PATH=${CMAKE_INSTALL_PREFIX:-${ICEBERG_HOME}}"
+)
+
+if is_windows; then
+
CMAKE_ARGS+=("-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake")
+ CMAKE_ARGS+=("-DCMAKE_BUILD_TYPE=Release")
Review Comment:
From my understanding there was an issue with debug builds on windows based
on the other PRs, right? Do we want to add a follow up issue to track building
with debug on Windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
