wgtmac commented on code in PR #34:
URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1928502982
##########
ci/scripts/build_example.sh:
##########
@@ -25,10 +25,27 @@ build_dir=${1}/build
mkdir ${build_dir}
pushd ${build_dir}
-cmake \
- -DCMAKE_PREFIX_PATH=${CMAKE_INSTALL_PREFIX:-${ICEBERG_HOME}} \
- ${source_dir}
-cmake --build .
+is_windows() {
+ [[ "${OSTYPE}" == "msys" || "${OSTYPE}" == "win32" ]]
+}
+
+CMAKE_ARGS=(
+ "-DCMAKE_PREFIX_PATH=${CMAKE_INSTALL_PREFIX:-${ICEBERG_HOME}}"
+)
+
+if is_windows; then
+
CMAKE_ARGS+=("-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake")
+ CMAKE_ARGS+=("-DCMAKE_BUILD_TYPE=Release")
Review Comment:
I have filed https://github.com/apache/iceberg-cpp/issues/39.
> Also, if you still want to have debug builds, probably better to choose
RelWithDebInfo rather than Release.
Good suggestion! I'll try it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
