kbendick commented on a change in pull request #1455:
URL: https://github.com/apache/iceberg/pull/1455#discussion_r487776448
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -80,6 +81,15 @@ public void stop() {
if (hiveLocalDir != null) {
hiveLocalDir.delete();
}
+
+ // remove raw store if exists
+ try {
+ Method cleanupRawStore =
HiveMetaStore.class.getDeclaredMethod("cleanupRawStore");
+ cleanupRawStore.setAccessible(true);
+ cleanupRawStore.invoke(null);
+ } catch (Exception e) {
+ // no op
+ }
Review comment:
It's usually a code smell to need to access a private method like this.
I get that these are just tests, but this feels like something that could
likely be handled via a specific config (perhaps in hive-conf.xml).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
