pvary commented on a change in pull request #1455:
URL: https://github.com/apache/iceberg/pull/1455#discussion_r487860927
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -80,6 +81,15 @@ public void stop() {
if (hiveLocalDir != null) {
hiveLocalDir.delete();
}
+
+ // remove raw store if exists
+ try {
+ Method cleanupRawStore =
HiveMetaStore.class.getDeclaredMethod("cleanupRawStore");
+ cleanupRawStore.setAccessible(true);
+ cleanupRawStore.invoke(null);
+ } catch (Exception e) {
+ // no op
+ }
Review comment:
Metastore has been never tested/used by stopping and starting in the
same process again and again. Hive tests are running in fork mode so this issue
has not been faced before. Gradle tests are running in a same process, and
changing the database connection URL which fouls up the db connection pool.
There is no config for this in Hive 😢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
