slfan1989 commented on code in PR #12853:
URL: https://github.com/apache/iceberg/pull/12853#discussion_r2051870105
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/TestFileIOSerialization.java:
##########
@@ -83,9 +83,7 @@ public void testHadoopFileIOKryoSerialization() throws
IOException {
FileIO deserializedIO =
KryoHelpers.roundTripSerialize(serializableTable.io());
Configuration actualConf = ((HadoopFileIO) deserializedIO).conf();
- assertThat(toMap(actualConf)).as("Conf pairs must
match").isEqualTo(toMap(expectedConf));
- assertThat(actualConf.get("k1")).as("Conf values must be
present").isEqualTo("v1");
- assertThat(actualConf.get("k2")).as("Conf values must be
present").isEqualTo("v2");
+ assertThat(actualConf).containsExactlyInAnyOrderElementsOf(expectedConf);
}
Review Comment:
Thank you for your contribution! I have a question, why were these two
`assertThat` removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
