tomtongue commented on code in PR #12853:
URL: https://github.com/apache/iceberg/pull/12853#discussion_r2051908975
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/TestFileIOSerialization.java:
##########
@@ -83,9 +83,7 @@ public void testHadoopFileIOKryoSerialization() throws
IOException {
FileIO deserializedIO =
KryoHelpers.roundTripSerialize(serializableTable.io());
Configuration actualConf = ((HadoopFileIO) deserializedIO).conf();
- assertThat(toMap(actualConf)).as("Conf pairs must
match").isEqualTo(toMap(expectedConf));
- assertThat(actualConf.get("k1")).as("Conf values must be
present").isEqualTo("v1");
- assertThat(actualConf.get("k2")).as("Conf values must be
present").isEqualTo("v2");
+ assertThat(actualConf).containsExactlyInAnyOrderElementsOf(expectedConf);
}
Review Comment:
Thanks for the comment. I believe the new one checks if the key-value pairs
match between `actualConf` and `expectedConf`, and also checks the existence of
the entries `(k1, v1)` and `(k2, v2)`. If there's something missing, please let
me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
