tomtongue commented on code in PR #12853:
URL: https://github.com/apache/iceberg/pull/12853#discussion_r2053475848
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -972,33 +974,38 @@ private void assertSnapshotFileCount(SnapshotTable
snapshotTable, String source,
long expectedFiles = expectedFilesCount(source);
SnapshotTable.Result snapshotTableResult = snapshotTable.execute();
validateTables(source, dest);
- Assert.assertEquals(
- "Expected number of imported snapshot files",
- expectedFiles,
- snapshotTableResult.importedDataFilesCount());
+ assertThat(snapshotTableResult.importedDataFilesCount())
+ .as("Expected number of imported snapshot files")
+ .isEqualTo(expectedFiles);
}
private void validateTables(String source, String dest)
throws NoSuchTableException, ParseException {
List<Row> expected = spark.table(source).collectAsList();
SparkTable destTable = loadTable(dest);
- Assert.assertEquals(
- "Provider should be iceberg",
- "iceberg",
- destTable.properties().get(TableCatalog.PROP_PROVIDER));
+ assertThat(destTable.properties().get(TableCatalog.PROP_PROVIDER))
Review Comment:
Thanks for checking this! Fix this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
