JingsongLi commented on a change in pull request #1509:
URL: https://github.com/apache/iceberg/pull/1509#discussion_r495695591
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java
##########
@@ -230,7 +215,7 @@ public void testSnapshotReads() throws Exception {
long timestampMillis = table.currentSnapshot().timestampMillis();
// produce another timestamp
- Thread.sleep(10);
+ waitUntilAfter(10);
Review comment:
Yes, you are right.
##########
File path: flink/src/test/java/org/apache/iceberg/flink/TestFlinkSchemaUtil.java
##########
@@ -252,7 +252,7 @@ public void testInconsistentTypes() {
Types.BinaryType.get(), new VarBinaryType(VarBinaryType.MAX_LENGTH),
new VarBinaryType(100), Types.BinaryType.get());
checkInconsistentType(
- Types.TimeType.get(), new TimeType(6),
+ Types.TimeType.get(), new TimeType(),
Review comment:
I will create one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
