JingsongLi commented on pull request #1509: URL: https://github.com/apache/iceberg/pull/1509#issuecomment-699778221
> Let's take a look at `ScanOptions` in the next PR then. I would prefer to keep user-facing APIs simple, rather than leaking a SQL concern (options come from `WITH`) to users (need to use two builders). Since SQL will most likely use the `fromProperties` method, it may make sense to use a single builder, add `withProperties`, and pass properties from SQL as a map. Got it, I think I can change the `ScanOptions` to `ScanContext`, it is an internal helper class like `TableScanContext`. Then expose all setters to `FlinkSource.Builder`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
