JingsongLi commented on a change in pull request #1517:
URL: https://github.com/apache/iceberg/pull/1517#discussion_r495719834
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/RowDataIterator.java
##########
@@ -92,12 +102,12 @@
return iter;
}
- private CloseableIterable<RowData> newAvroIterable(FileScanTask task,
Map<Integer, ?> idToConstant) {
+ private CloseableIterable<RowData> newAvroIterable(FileScanTask task, Schema
schema, Map<Integer, ?> idToConstant) {
Avro.ReadBuilder builder = Avro.read(getInputFile(task))
- .reuseContainers()
- .project(projectedSchema)
+ .reuseContainers(false)
Review comment:
I have a slight -1 for option, If there are no side effects, why do we
need to provide this option? (testing is not a good example, we should consider
user-face interface)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
