JingsongLi commented on a change in pull request #1517:
URL: https://github.com/apache/iceberg/pull/1517#discussion_r495724642
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/RowDataIterator.java
##########
@@ -92,12 +102,12 @@
return iter;
}
- private CloseableIterable<RowData> newAvroIterable(FileScanTask task,
Map<Integer, ?> idToConstant) {
+ private CloseableIterable<RowData> newAvroIterable(FileScanTask task, Schema
schema, Map<Integer, ?> idToConstant) {
Avro.ReadBuilder builder = Avro.read(getInputFile(task))
- .reuseContainers()
- .project(projectedSchema)
+ .reuseContainers(false)
Review comment:
And if this reuse flap is false, I think there may also be some risks.
Note in Flink and Spark reader, we are reusing binary for StringReader.
Maybe these binaries are chunk buffers that have been reused by parquet
reader (CC: @rdblue), so even if reuse flag is false, users cannot assume
returning row's security.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
