chenjunjiedada commented on a change in pull request #1517:
URL: https://github.com/apache/iceberg/pull/1517#discussion_r496477503
##########
File path: data/src/test/java/org/apache/iceberg/data/DeletesReadTest.java
##########
@@ -240,17 +252,11 @@ public void testEqualityDeleteByNull() throws IOException
{
Assert.assertEquals("Table should contain expected rows", expected,
actual);
}
- private static StructLikeSet rowSet(Table table) throws IOException {
- return rowSet(table, "*");
+ private StructLikeSet rowSet(Table tbl) throws IOException {
+ return rowSet(tbl, "*");
Review comment:
The `checkstyle` reports hidden variable issue because it has the same
name between the parameter and class member. I updated the member `table` to
`testTable` in the PR. will rebase this accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
