rdblue commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r496911872
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -139,6 +140,8 @@ protected void doRefresh() {
@Override
protected void doCommit(TableMetadata base, TableMetadata metadata) {
+ boolean updateTable = base != null ||
metadata.propertyAsBoolean(TABLE_FROM_HIVE, false);
Review comment:
I agree that this should not change the `TableMetadata` that was passed
in. If we pass the flag in `TableMetadata`, then it would be stored in the
Iceberg metadata.
But why can't we add this flag to the HMS table that is passed to the
pre-commit phase in the Hive hooks? If we add it to the Hive table that gets
created and should be replaced, then there is no need to pass it in Iceberg
metadata. And we can remove it when we create the Iceberg table underneath and
set the metadata location.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
