pvary commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r497029188
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -139,6 +140,8 @@ protected void doRefresh() {
@Override
protected void doCommit(TableMetadata base, TableMetadata metadata) {
+ boolean updateTable = base != null ||
metadata.propertyAsBoolean(TABLE_FROM_HIVE, false);
Review comment:
Uploaded the change.
We need to call HMSClient.getTable every time in
HiveTableOperations.doCommit, so we can decide if this is a new table or
already created by the Hook.
This is an extra call in case the new table creation is started from Spark.
This might be acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
