nastra commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r2182287855


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -82,11 +83,15 @@ public class AwsClientProperties implements Serializable {
   /** Controls whether vended credentials should be refreshed or not. Defaults 
to true. */
   public static final String REFRESH_CREDENTIALS_ENABLED = 
"client.refresh-credentials-enabled";
 
+  /** Controls whether legacy md5 plugin should be added or not. Defaults to 
false. */

Review Comment:
   we might also want to include the wording from 
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/LegacyMd5Plugin.html
 here to make it clear for users



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to