nastra commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r2182285017
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -82,11 +83,15 @@ public class AwsClientProperties implements Serializable {
/** Controls whether vended credentials should be refreshed or not. Defaults
to true. */
public static final String REFRESH_CREDENTIALS_ENABLED =
"client.refresh-credentials-enabled";
+ /** Controls whether legacy md5 plugin should be added or not. Defaults to
false. */
Review Comment:
we might want to improve the docs here and mention what this flag does
exactly as it won't be obvious to most people what this flag actually does. I
would probably add some description that says the SDK's behavior changed in
version X and therefore affects S3-compliant storage implementations since that
version and such
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
