RussellSpitzer commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499698588
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkDataFile.java
##########
@@ -77,19 +98,47 @@ public SparkDataFile(Types.StructType type, StructType
sparkType) {
upperBoundsPosition = positions.get("upper_bounds");
keyMetadataPosition = positions.get("key_metadata");
splitOffsetsPosition = positions.get("split_offsets");
+ specIdPosition = positions.get("partition_spec_id");
+ }
+
+ private SparkDataFile(SparkDataFile other) {
Review comment:
Copy constructor since we need to actually serialize this representation
back to Spark when we distributed CombinedScanTasks. This means we actually
need a SparkDataFile object for every BaseFileScanTask
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]