rdblue commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499779393
##########
File path: core/src/main/java/org/apache/iceberg/V1Metadata.java
##########
@@ -213,7 +213,8 @@ static Schema wrapFileSchema(Types.StructType fileSchema) {
DataFile.LOWER_BOUNDS,
DataFile.UPPER_BOUNDS,
DataFile.KEY_METADATA,
- DataFile.SPLIT_OFFSETS
+ DataFile.SPLIT_OFFSETS,
+ ManifestFile.SPEC_ID.asOptional()
Review comment:
This is the v1 write schema. Since we don't need to write spec IDs into
manifests, I don't think that we need to add this here or to update to add it
below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
