rdblue commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499776993
##########
File path: core/src/main/java/org/apache/iceberg/BaseFileScanTask.java
##########
@@ -29,7 +29,7 @@
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
-class BaseFileScanTask implements FileScanTask {
+public class BaseFileScanTask implements FileScanTask {
Review comment:
I think maybe we should have a factory method somewhere in the public
API instead? We don't necessarily want to expose everything here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
