pan3793 commented on code in PR #13106:
URL: https://github.com/apache/iceberg/pull/13106#discussion_r2184173549
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestFastForwardBranchProcedure.java:
##########
@@ -167,18 +167,21 @@ public void testInvalidFastForwardBranchCases() {
sql(
"CALL %s.system.fast_forward('test_table', branch =>
'main', to => 'newBranch')",
catalogName))
- .isInstanceOf(AnalysisException.class)
- .hasMessage("Named and positional arguments cannot be mixed");
+ .isInstanceOf(RuntimeException.class)
+ .hasMessageStartingWith("Couldn't load table");
Review Comment:
Actually, this becomes a legal case in Spark's named args resolution
Spark requires:
- the named arguments don't contains positional arguments once keyword
arguments start
- the named arguments don't use the duplicated names
that's say
```
-- illegal in Iceberg, legal in Spark
CALL catalog.system.fast_forward('test_table', branch => 'main', to =>
'newBranch')
-- illegal in both Iceberg and Spark
CALL catalog.system.fast_forward(table => 'test_table', 'main', to =>
'newBranch')
```
I have to change it to the latter to make the test meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
