pan3793 commented on code in PR #13106:
URL: https://github.com/apache/iceberg/pull/13106#discussion_r2184185956
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/AncestorsOfProcedure.java:
##########
@@ -62,18 +67,23 @@ protected AncestorsOfProcedure doBuild() {
};
}
+ @Override
+ public BoundProcedure bind(StructType inputType) {
+ return this;
+ }
+
@Override
public ProcedureParameter[] parameters() {
return PARAMETERS;
}
@Override
- public StructType outputType() {
- return OUTPUT_TYPE;
+ public boolean isDeterministic() {
+ return false;
Review Comment:
This hasn't been used by Spark yet.
I conservatively assume that all procedures are indeterministic to avoid
unexpected behavior. For this procedure, it can return a different result after
the snapshot expires
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
