nastra commented on code in PR #13106:
URL: https://github.com/apache/iceberg/pull/13106#discussion_r2185343145
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java:
##########
@@ -76,18 +81,23 @@ private RewriteTablePathProcedure(TableCatalog
tableCatalog) {
super(tableCatalog);
}
+ @Override
+ public BoundProcedure bind(StructType inputType) {
+ return this;
+ }
+
@Override
public ProcedureParameter[] parameters() {
return PARAMETERS;
}
@Override
- public StructType outputType() {
- return OUTPUT_TYPE;
+ public boolean isDeterministic() {
Review Comment:
maybe this method can go into `BaseProcedure` since the return value is the
same across all procedures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
