RussellSpitzer commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499789454
##########
File path: core/src/main/java/org/apache/iceberg/V1Metadata.java
##########
@@ -213,7 +213,8 @@ static Schema wrapFileSchema(Types.StructType fileSchema) {
DataFile.LOWER_BOUNDS,
DataFile.UPPER_BOUNDS,
DataFile.KEY_METADATA,
- DataFile.SPLIT_OFFSETS
+ DataFile.SPLIT_OFFSETS,
+ ManifestFile.SPEC_ID.asOptional()
Review comment:
The issue with this is that we have tests which compare schemas, if the
field is not listed here it still gets included from Datafile which makes the
comparisons
"partition_spec_id" vs "partition_spec_id_r502" which fails. So I mostly
added it here so the test would pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
