RussellSpitzer commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499791267
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -45,7 +45,7 @@
* Base class for {@link TableScan} implementations.
*/
@SuppressWarnings("checkstyle:OverloadMethodsDeclarationOrder")
-abstract class BaseTableScan implements TableScan {
+public abstract class BaseTableScan implements TableScan {
Review comment:
TableOps and Options, I'm not sure we want TableOps to be public but
Options feels like it should have been public already, currently only "option"
is public for setting an option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
