RussellSpitzer commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499792334
##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -80,7 +80,8 @@ static StructType getType(StructType partitionType) {
UPPER_BOUNDS,
KEY_METADATA,
SPLIT_OFFSETS,
- EQUALITY_IDS
+ EQUALITY_IDS,
+ ManifestFile.SPEC_ID.asOptional()
Review comment:
This is optional so Avro won't fail when we attempt to read a file which
does not contain this field, this makes it so we don't have to modify the
reader and can still have a slot for the SpecID. You can check some of my older
commits for some other ways I tried to do this which involved a bit more ...
grossness.
https://github.com/apache/iceberg/pull/1421/commits/4f16c8cf86dc808fb1e7015982827649d3e377f8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
