simonsssu commented on a change in pull request #1515:
URL: https://github.com/apache/iceberg/pull/1515#discussion_r502376629
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java
##########
@@ -145,6 +147,38 @@ public void testWriteRowData() throws Exception {
SimpleDataUtil.assertTableRows(tablePath, expectedRows);
}
+ @Test
+ public void testWriteRowDataWithoutCheckpoint() throws Exception {
+ List<Row> rows = Lists.newArrayList(
+ Row.of(1, "hello"),
+ Row.of(2, "world"),
+ Row.of(3, "foo")
+ );
+
+ env = StreamExecutionEnvironment.getExecutionEnvironment()
+ .setParallelism(parallelism)
+ .setMaxParallelism(parallelism);
+
+ DataStream<RowData> dataStream = env.addSource(new
NonCheckpointFiniteTestSource<>(rows), ROW_TYPE_INFO)
+ .map(CONVERTER::toInternal,
RowDataTypeInfo.of(SimpleDataUtil.ROW_TYPE));
+
+ org.apache.flink.configuration.Configuration flinkConf = new
org.apache.flink.configuration.Configuration();
+ flinkConf.setLong(FlinkSink.FLINK_ICEBERG_SINK_FLUSHINTERVAL, 100L);
+
+ FlinkSink.forRowData(dataStream)
+ .table(table)
Review comment:
You are right, it's no need to add this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
