simonsssu commented on a change in pull request #1515:
URL: https://github.com/apache/iceberg/pull/1515#discussion_r502389602
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java
##########
@@ -528,7 +528,8 @@ private static TestOperatorFactory of(String tablePath) {
@Override
@SuppressWarnings("unchecked")
public <T extends StreamOperator<Void>> T
createStreamOperator(StreamOperatorParameters<Void> param) {
- IcebergFilesCommitter committer = new
IcebergFilesCommitter(TableLoader.fromHadoopTable(tablePath), CONF, false);
+ IcebergFilesCommitter committer = new
IcebergFilesCommitter(TableLoader.fromHadoopTable(tablePath), CONF, false,
Review comment:
You are right, I will add more UTs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
