simonsssu commented on a change in pull request #1515:
URL: https://github.com/apache/iceberg/pull/1515#discussion_r502393420
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -73,7 +75,9 @@
// TableLoader to load iceberg table lazily.
private final TableLoader tableLoader;
private final SerializableConfiguration hadoopConf;
+ private final org.apache.flink.configuration.Configuration flinkConf;
private final boolean replacePartitions;
+ private final long flushCommitInterval;
Review comment:
Yes, here I think it's better to use commitInterval rather than
flushCommitInterval.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
