dramaticlly commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2229729546
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -121,180 +121,143 @@ public TableOperations underlyingOps() {
return ops;
}
- private void checkLastOperationCommitted(String operation) {
+ protected <T extends PendingUpdate> T appendUpdates(T update) {
+ if (!(update instanceof ManageSnapshots)) {
Review Comment:
Let me see if this mermaid chart helps,
- solid arrow for extend class
- dotted line for implements interface
```mermaid
classDiagram
class SnapshotUpdate {
<<interface>>
}
class AppendFiles {
<<interface>>
}
class SnapshotProducer {
<<abstract class>>
}
class FastAppend {
}
class PendingUpdate {
<<interface>>
}
PendingUpdate <|-- SnapshotUpdate
SnapshotUpdate <|-- AppendFiles
SnapshotUpdate <|.. SnapshotProducer
AppendFiles <|.. FastAppend
SnapshotProducer <|-- FastAppend
FastAppend : implements AppendFiles
FastAppend : extends SnapshotProducer
BaseTransaction o-- FastAppend: instantiate
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
