rdblue commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2237931079
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -56,7 +56,7 @@
public class BaseTransaction implements Transaction {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTransaction.class);
- enum TransactionType {
+ protected enum TransactionType {
Review Comment:
Rather than exposing this, could we add public factory methods?
`newReplaceTransaction(...)` for example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
