RussellSpitzer commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2236763451
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -121,180 +121,143 @@ public TableOperations underlyingOps() {
return ops;
}
- private void checkLastOperationCommitted(String operation) {
+ protected <T extends PendingUpdate> T appendUpdates(T update) {
+ if (!(update instanceof ManageSnapshots)) {
Review Comment:
This all feels to me like a much more complicated solution than the original
patch. Especially if the extender wants to add new updates which don't match
the original apis (YourTransaction.newTTLDelete,
YourTransaction.newNonTransactionalReplace or what not). I think at this point
I think I would prefer we go back to the original approach just using
instanceOf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
