JingsongLi commented on a change in pull request #1565:
URL: https://github.com/apache/iceberg/pull/1565#discussion_r502275412
##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -43,18 +44,18 @@ static CatalogLoader hive(String name, Configuration
hadoopConf, String uri, int
class HadoopCatalogLoader implements CatalogLoader {
private final String catalogName;
- private final Configuration hadoopConf;
+ private final SerializableConfiguration hadoopConf;
Review comment:
This is already tested by ITCases. It is the only way which must be
passed.
But unit test can be added too.
##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -43,18 +44,18 @@ static CatalogLoader hive(String name, Configuration
hadoopConf, String uri, int
class HadoopCatalogLoader implements CatalogLoader {
private final String catalogName;
- private final Configuration hadoopConf;
+ private final SerializableConfiguration hadoopConf;
Review comment:
This is already tested by ITCases. It is the only way which must be
passed.
But we can add more unit tests too.
##########
File path: flink/src/main/java/org/apache/iceberg/flink/TableLoader.java
##########
@@ -45,23 +46,30 @@ static TableLoader fromCatalog(CatalogLoader catalogLoader,
TableIdentifier iden
}
static TableLoader fromHadoopTable(String location) {
Review comment:
I think it is useful for users, since Flink has default hadoop
configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
