openinx commented on a change in pull request #1565:
URL: https://github.com/apache/iceberg/pull/1565#discussion_r502257571
##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -43,18 +44,18 @@ static CatalogLoader hive(String name, Configuration
hadoopConf, String uri, int
class HadoopCatalogLoader implements CatalogLoader {
private final String catalogName;
- private final Configuration hadoopConf;
+ private final SerializableConfiguration hadoopConf;
Review comment:
Nice catch, since the `CatalogLoader` need to be serializable, so all
members need to be serializable. Do we need to add several unit tests to
address the serializable issue so that we won't break it in future ? similar
to the unit test TestScanTaskSerialization ?
##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -43,18 +44,18 @@ static CatalogLoader hive(String name, Configuration
hadoopConf, String uri, int
class HadoopCatalogLoader implements CatalogLoader {
private final String catalogName;
- private final Configuration hadoopConf;
+ private final SerializableConfiguration hadoopConf;
Review comment:
`TableLoader` need the similar unit test.
##########
File path: flink/src/main/java/org/apache/iceberg/flink/TableLoader.java
##########
@@ -45,23 +46,30 @@ static TableLoader fromCatalog(CatalogLoader catalogLoader,
TableIdentifier iden
}
static TableLoader fromHadoopTable(String location) {
Review comment:
Is this only visible for testing ? Moving to test package ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
