dramaticlly commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2240433244
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -56,7 +56,7 @@
public class BaseTransaction implements Transaction {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTransaction.class);
- enum TransactionType {
+ protected enum TransactionType {
Review Comment:
I also moved the constructor method back to package private, as
TransactionType is part of its constructor parameter to keep consistent
visibility. I think it's a good compromise to only vend out new transactions in
factory class located in `org.apache.iceberg` package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
