itamarwe opened a new pull request, #13750:
URL: https://github.com/apache/iceberg/pull/13750
## Changes Made
### Core Implementation
- **`RESTCatalogServer.java`**:
- Added `CATALOG_NAME` constant (`"catalog.name"`) and
`CATALOG_NAME_DEFAULT` (`"rest_backend"`)
- Modified `initializeBackendCatalog()` to read catalog name from
properties with fallback to default
- Added logging to track which catalog name is being used
- Replaced hardcoded `"rest_backend"` with configurable `catalogName`
parameter
- **`RCKUtils.java`**:
- Added catalog name property to test configuration with default value
- Ensures test environment uses the same configurable catalog name approach
### Testing
- **`TestRESTCatalogServer.java`** (new file):
- Added comprehensive test suite with 3 test methods:
- `testCatalogNameDefault()`: Verifies default catalog name behavior
- `testCatalogNameFromConfig()`: Tests custom catalog name configuration
- `testEnvironmentVariableMapping()`: Tests environment variable mapping
pattern
## Summary
This PR successfully implements configurable catalog naming by:
1. Adding the `CATALOG_NAME` property to `RESTCatalogServer`
2. Updating test configuration in `RCKUtils`
3. Creating comprehensive tests in `TestRESTCatalogServer`
4. Maintaining backward compatibility with existing deployments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
