itamarwe commented on PR #13750: URL: https://github.com/apache/iceberg/pull/13750#issuecomment-3172121228
It’s used as the catalog name in the underlying catalog. For example, in JDBC it’s stored in the catalog name column and allows multiple REST catalogs to use the same JDBC backend (which is what motivated us). On Sat, Aug 9, 2025 at 21:53 Kevin Liu ***@***.***> wrote: > ***@***.**** commented on this pull request. > > thanks for the pr! i understand the intent of making the catalog name > configurable but im not sure we even use the catalog name for any purposes. > ------------------------------ > > In > open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java > <https://github.com/apache/iceberg/pull/13750#discussion_r2264920291>: > > > LOG.info("Creating catalog with properties: {}", catalogProperties); > return new CatalogContext( > - CatalogUtil.buildIcebergCatalog("rest_backend", catalogProperties, new Configuration()), > + CatalogUtil.buildIcebergCatalog(catalogName, catalogProperties, new Configuration()), > > afaik the catalog name is just a placeholder and not used for anything. i > dont think we even reference the catalog by name. > > for example, in the RCKUtils class, the name is set to another string > constant > > https://github.com/apache/iceberg/blob/c8c61a3f6b60499f09e5047c5c9d8a3c02d9fb72/open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java#L122 > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/13750#pullrequestreview-3103207301>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFXKMR45XSVH7FUE3CYLDD3MY7SDAVCNFSM6AAAAACDHHT2TCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMBTGIYDOMZQGE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
