itamarwe commented on code in PR #13750:
URL: https://github.com/apache/iceberg/pull/13750#discussion_r2265107658
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -92,9 +95,14 @@ private CatalogContext initializeBackendCatalog() throws
IOException {
LOG.info("No warehouse location set. Defaulting to temp location: {}",
warehouseLocation);
}
+ // Get catalog name from environment or use default
+ String catalogName =
+ PropertyUtil.propertyAsString(catalogProperties, CATALOG_NAME,
CATALOG_NAME_DEFAULT);
+ LOG.info("Using catalog name: {}", catalogName);
+
LOG.info("Creating catalog with properties: {}", catalogProperties);
return new CatalogContext(
- CatalogUtil.buildIcebergCatalog("rest_backend", catalogProperties, new
Configuration()),
+ CatalogUtil.buildIcebergCatalog(catalogName, catalogProperties, new
Configuration()),
Review Comment:
Here it's not a placeholder. When we call `buildIcebergCatalog` it actually
uses the parameter when building the underlying backend catalog. For example,
for a JDBC catalog it will use the catalog name and put it in the
`CATALOG_NAME` column.
Here in the JDBCUtil the catalog name is used in the WHERE clause:
https://github.com/apache/iceberg/blob/c8c61a3f6b60499f09e5047c5c9d8a3c02d9fb72/core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java#L70-L72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
