ebyhr commented on code in PR #13750:
URL: https://github.com/apache/iceberg/pull/13750#discussion_r2280712659
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -92,9 +95,14 @@ private CatalogContext initializeBackendCatalog() throws
IOException {
LOG.info("No warehouse location set. Defaulting to temp location: {}",
warehouseLocation);
}
+ // Get catalog name from environment or use default
Review Comment:
nit: This comment isn't helpful to me. It's obvious when reading the
following code.
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -92,9 +95,14 @@ private CatalogContext initializeBackendCatalog() throws
IOException {
LOG.info("No warehouse location set. Defaulting to temp location: {}",
warehouseLocation);
}
+ // Get catalog name from environment or use default
+ String catalogName =
+ PropertyUtil.propertyAsString(catalogProperties, CATALOG_NAME,
CATALOG_NAME_DEFAULT);
+ LOG.info("Using catalog name: {}", catalogName);
Review Comment:
nit: We could merge this line and another logging at L103 into one:
```java
LOG.info("Creating {} catalog with properties: {}", catalogName,
catalogProperties);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
