kevinjqliu commented on code in PR #13750:
URL: https://github.com/apache/iceberg/pull/13750#discussion_r2265363220
##########
open-api/src/test/java/org/apache/iceberg/rest/RESTCatalogServerTest.java:
##########
Review Comment:
not sure if this test is useful. the files here are for the test suite, not
unit tests.
maybe we should test locally that `catalog.name` can be passed in via env var
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java:
##########
@@ -96,6 +96,8 @@ static RESTCatalog initCatalogClient(Map<String, String>
properties) {
catalogProperties.putIfAbsent(
CatalogProperties.URI, String.format("http://localhost:%s/";, port));
catalogProperties.putIfAbsent(CatalogProperties.WAREHOUSE_LOCATION,
"rck_warehouse");
+ catalogProperties.putIfAbsent(
+ RESTCatalogServer.CATALOG_NAME,
RESTCatalogServer.CATALOG_NAME_DEFAULT);
Review Comment:
this is the client side when interacting with the REST server. i dont think
we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
