rdblue commented on a change in pull request #1612:
URL: https://github.com/apache/iceberg/pull/1612#discussion_r511144687
##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestTables.java
##########
@@ -172,5 +221,18 @@ public String identifier(String tableIdentifier) {
public Map<String, String> properties() {
return ImmutableMap.of(InputFormatConfig.CATALOG, "hive");
}
+
+ @Override
+ public String locationForCreateTableSQL(TableIdentifier identifier) {
+ return "";
Review comment:
Empty string defaults are very suspicious to me. Why not use null here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
