pvary commented on pull request #1612:
URL: https://github.com/apache/iceberg/pull/1612#issuecomment-714394653
@rdblue: I will be on PTO next week and I will do my best to not open my
laptop during that time 😄. So it is absolutely ok if you review the patch only
sometime next week. It would be good to have the main points identified here
and in #1407 as well, so after the PTO I can start fixing those with fresh
energies 😄
I start to feel more-more convinced that we should not reuse the Hive
`PARTITIONED BY` clause to create Iceberg partitioned tables because of the
following reasons:
- The resulting table will/should be non-partitioned in Hive and this is
non-intuitive for the users (creating a partitioned table, and getting a
non-partitioned one)
- We can create only identity partition specifications this way which is
very limited in contrast to the nice feature set already provided by Iceberg.
If you agree, I would throw an error in the next iteration of this PR when
the user tries to create a partitioned table with the `PARTITIONED BY` clause.
The `TBLPROPERTIES` still could be used to create the full range of Iceberg
partitions. In one of my next PRs, I will try to find a better solution for
creating Iceberg partitioned tables with a normal SQL statement without using
JSON-s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
