shardulm94 commented on a change in pull request #1566:
URL: https://github.com/apache/iceberg/pull/1566#discussion_r505847585
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -582,6 +582,13 @@ public ReadBuilder withNameMapping(NameMapping
newNameMapping) {
optionsBuilder = ParquetReadOptions.builder();
}
+ if (filter != null &&
+ schema.getAliases() != null &&
+ ParquetFilters.isSupportedFilter(filter, schema,
caseSensitive)) {
+ optionsBuilder.useRecordFilter(filterRecords);
Review comment:
Seems like what we want here is `useColumnIndexFilter` and not
`useRecordFilter` else `readNextFilteredRowGroup()` is equivalent to
`readNextRowGroup()`
https://github.com/apache/parquet-mr/blob/fe9ab5d22c602776f44b027ad3cc05609eddba54/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
