shardulm94 commented on a change in pull request #1566:
URL: https://github.com/apache/iceberg/pull/1566#discussion_r505884115
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -582,6 +582,13 @@ public ReadBuilder withNameMapping(NameMapping
newNameMapping) {
optionsBuilder = ParquetReadOptions.builder();
}
+ if (filter != null &&
+ schema.getAliases() != null &&
Review comment:
The Iceberg table schema will probably rarely have aliases. I think
after my recommendation at
https://github.com/apache/iceberg/pull/1566#discussion_r505689098 you should no
longer see the NPE and this check can be removed.
I think this is also in alignment with what @rdblue says at
https://github.com/apache/iceberg/issues/193#issuecomment-692390785
> When converting to the Parquet FilterApi, the aliases must come from a
Schema instance that was created from the MessageType of the file you're
pushing filters to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
