shangxinli commented on a change in pull request #1566:
URL: https://github.com/apache/iceberg/pull/1566#discussion_r505901768
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -582,6 +582,13 @@ public ReadBuilder withNameMapping(NameMapping
newNameMapping) {
optionsBuilder = ParquetReadOptions.builder();
}
+ if (filter != null &&
+ schema.getAliases() != null &&
+ ParquetFilters.isSupportedFilter(filter, schema,
caseSensitive)) {
+ optionsBuilder.useRecordFilter(filterRecords);
+ optionsBuilder.withRecordFilter(ParquetFilters.convert(schema,
filter, caseSensitive));
Review comment:
Do you recommend to move "type =
schemaReader.getFileMetaData().getSchema()" to the beginning of this method so
that we can use the file schema instead of table schema? I worry it could
result in more storage API calls because when the condition "if (readerFunc !=
null || batchedReaderFunc != null)" is true, we don't have this API call today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
