amogh-jahagirdar commented on code in PR #14035: URL: https://github.com/apache/iceberg/pull/14035#discussion_r2335196208
########## api/src/main/java/org/apache/iceberg/exceptions/NotModifiedException.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.exceptions; + +import com.google.errorprone.annotations.FormatMethod; + +/** Exception to indicate that resource is unchanged. */ +public class NotModifiedException extends RESTException { Review Comment: OK I guess the argument against doing it in the http client is that if we just return null, it's a bit weird for clients to now have to worry about if (loadTableResponse != null) if it's a 304 vs getting an explicit exception and handling that way... I think I still prefer putting this logic in the HTTP client instead of having a separate error because all this handling is anyways contained in `RESTSessionCatalog` and abstracted away from users anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
