pvary commented on code in PR #14035: URL: https://github.com/apache/iceberg/pull/14035#discussion_r2358518093
########## api/src/main/java/org/apache/iceberg/exceptions/NotModifiedException.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.exceptions; + +import com.google.errorprone.annotations.FormatMethod; + +/** Exception to indicate that resource is unchanged. */ +public class NotModifiedException extends RESTException { Review Comment: @amogh-jahagirdar: How do we look at the RESTCatalogAdapter? 1. Is this just a reference implementation which show how should things work, and which could be used for testing the REST Client, or 2. Is it supposed to be a production ready code? I'm asking, because for the 1st we need the simplest, most readable code. In this case I would prefer the `NotModifiedException` which clearly describes what is happening. If we aim for production code, I would prefer to avoid handling typical cases with exceptions. In this case, I would probably prefer returning a Pair<Changed, Table>, or some other specific object based solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
