gaborkaszab commented on code in PR #14035: URL: https://github.com/apache/iceberg/pull/14035#discussion_r2358712730
########## api/src/main/java/org/apache/iceberg/exceptions/NotModifiedException.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.exceptions; + +import com.google.errorprone.annotations.FormatMethod; + +/** Exception to indicate that resource is unchanged. */ +public class NotModifiedException extends RESTException { Review Comment: Thank you for taking a look, @pvary ! The thing with changing response types (and parameters) is that it is an API breaking change. Not directly for `RESTCatalogAdapter.handleRequest()` but for the calling `RESTCatalogAdapter.execute()` that invokes this, because it is an override of `HTTPRequest.execute()`. So with the current design of the reference IRC, I think we can either follow the exception driven approach, or implement some (not that foolproof) checks in `RESTCatalogServlet` like "if the responseBody is null and the load table endpoint was called, then return 304". The exception-driven approach seems to be the cleanest on the reference IRC side. cc @amogh-jahagirdar @nastra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
