stevenzwu edited a comment on issue #1643:
URL: https://github.com/apache/iceberg/issues/1643#issuecomment-714874835
- How would IcebergSourceSplitReader<T> know how to create a reuseable empty
object array for a generic type T?
- How would IcebergSourceSplitReader<T> know how to clone the generic type T
returned by DataIterator.next()?
We already added a `DataIteratorFactory` on how to create an iterator from
split. I think we can extend the interface on how create and clone objects.
```
public class RowDataIteratorFactory implements DataIteratorFactory<RowData> {
@Override
public DataIterator<RowData> createIterator(
IcebergSourceSplit split,
TableInfo tableInfo,
ScanContext scanContext) {
return new RowDataIterator(...);
}
```
The unclear question for is still what should be reuse behavior for Flink
source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
