openinx commented on issue #1643: URL: https://github.com/apache/iceberg/issues/1643#issuecomment-714883579
> The unclear question for is still what should be reuse behavior for Flink source. I read the [DataSourceTask](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java#L181) code, there's a `objectReuse` ( default value is false) from `ExecutionConfig` to indicate whether we should enable object reuse. I also checked the [RecordWriter](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java#L100), for every emited record, it would serialized into a ByteBuffer . So in theory, regardless of enabling or disabling object reuse, it actually would copy the object into a totally new ByteBuffer, we don't have to worry about the objects messing up issue caused by reuse at flink runtime at least. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
