stevenzwu edited a comment on issue #1643: URL: https://github.com/apache/iceberg/issues/1643#issuecomment-714913878
@openinx I updated [the patch](https://github.com/stevenzwu/iceberg/pull/1/files). You can find the iterator factory change [here](https://github.com/stevenzwu/iceberg/blob/flip27IcebergSource/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java#L93-L100). Right now, it is just doing simple clone if iterator returns reused object. for Avro iterator (which already returns new objects), we don't need to clone again. BTW, some unit tests still fail. so it is not completely working. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
